Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inheritance bug breaks ItemsComponentModel chain. #2415

Closed
oliverfoster opened this issue Apr 12, 2019 · 1 comment
Closed

Inheritance bug breaks ItemsComponentModel chain. #2415

oliverfoster opened this issue Apr 12, 2019 · 1 comment
Assignees
@oliverfoster
Labels
bug

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Apr 12, 2019 •
edited
Loading

Subject of the issue

ItemsComponentModel ends up inheriting from QuestionModel due to the poor creation of ItemsQuestionModel. The ItemsComponentModel constructor function is extended in error.
@oliverfoster oliverfoster self-assigned this Apr 12, 2019
@oliverfoster oliverfoster mentioned this issue Apr 12, 2019
Merged
@moloko
Copy link
Contributor

moloko commented May 13, 2019

done in b6988c3

@moloko moloko closed this as completed May 13, 2019
@moloko moloko changed the title Inheritance bug breaks ItemComponentModel chain. Inheritance bug breaks ItemsComponentModel chain. Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moloko @oliverfoster