Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notify: make a hard API #2532

Closed
oliverfoster opened this issue Sep 30, 2019 · 1 comment
Closed

notify: make a hard API #2532

oliverfoster opened this issue Sep 30, 2019 · 1 comment
Assignees
@oliverfoster
Labels
enhancement

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Sep 30, 2019 •
edited by moloko
Loading

Subject of the issue

Currently a notify instance is created by triggering a backbone event. It should be a hard API as there is only ever one end point.

Current:

Adapt.trigger('notify:alert', notifyObject);

Suggested:

Adapt.notify.alert(notifyObject);
@oliverfoster oliverfoster self-assigned this Sep 30, 2019
@oliverfoster oliverfoster mentioned this issue Sep 30, 2019
Merged
@moloko
Copy link
Contributor

moloko commented Oct 3, 2019

related - see #2540 for documentation changes

https:/adaptlearning/adapt_framework/wiki/Core-modules#notify has been updated as well

moloko added a commit that referenced this issue Oct 3, 2019
@moloko
update CHANGELOG with #2532
52db705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moloko @oliverfoster