Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE doesn't support method syntax #2570

Closed
chetan-hajare opened this issue Nov 5, 2019 · 3 comments · Fixed by #2571
Closed

IE doesn't support method syntax #2570

chetan-hajare opened this issue Nov 5, 2019 · 3 comments · Fixed by #2571

Comments

@chetan-hajare
Copy link

chetan-hajare commented Nov 5, 2019

Subject of the issue

The below function definition is not supported in IE Here

{
    url: "http://example.com/example.txt",
    test(data) // <==== here
    {
        // ...
    }
}

Your environment

Framework: 4.4.0
Browser: IE11

Steps to reproduce

Build and run the latest framework

Expected behaviour

The course should run properly on IE11

Actual behaviour

Throws console error on IE11

@moloko
Copy link
Contributor

moloko commented Nov 5, 2019

is that line reference correct? it currently points to the function definition for setPopupCloseTo

@moloko
Copy link
Contributor

moloko commented Nov 5, 2019

ah OK I see what you mean - accidental use of ES6 function definition!

@moloko
Copy link
Contributor

moloko commented Nov 5, 2019

@chetan-hajare is this something you're fixing? if not I can pick this up quickly as it's a pretty serious problem! No idea how this didn't get picked up in testing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants