Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot graphic popup not re-centering vertically when 'paging' between items #2580

Closed
chris-steele opened this issue Nov 13, 2019 · 5 comments
Closed
Assignees
Labels

Comments

@chris-steele
Copy link
Contributor

Subject of the issue/enhancement/features

When moving between items using the back/next buttons the notify popup will not re-center itself vertically to accommodate items with differing amounts of content.

Your environment

  • version v4.4.x, release/v5
  • all browsers
  • all platforms
@oliverfoster
Copy link
Member

We probably need a jquery.resize enabled listener on the subview container here-ish
to trigger resetNotifySize which is then removed here-ish

    
    // bind in initialize
    _.bindAll(this, 'resetNotifySize');

    // attach in opened when adding a subview
    this.subView.$el.on("resize", this.resetNotifySize);

    // then remove before removing subview
    this.subView.$el.off("resize", this.resetNotifySize);

@chris-steele
Copy link
Contributor Author

That looks good and seems to work just fine. Have put it into a project and will report back.

@oliverfoster
Copy link
Member

oliverfoster commented Nov 13, 2019

Does it solve the other ticket? #2579

@oliverfoster oliverfoster self-assigned this Nov 13, 2019
@chris-steele
Copy link
Contributor Author

Sadly not :(

@oliverfoster
Copy link
Member

Needs v4 pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants