Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Grunt task create-json-config #2660

Closed
oliverfoster opened this issue Feb 26, 2020 · 2 comments
Closed

Question: Grunt task create-json-config #2660

oliverfoster opened this issue Feb 26, 2020 · 2 comments
Assignees
Labels

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Feb 26, 2020

Question

Can I delete the grunt task create-json-config ?

Details

The grunt task create-json-config collects the following files and tries to merge them into the build/course/config.json:

 'src/components/*/components.json',
 'src/extensions/*/extensions.json',
 'src/menu/*/menu.json',
 'src/theme/*/theme.json',
 'src/*/*/config.json'

This is not a feature the Authoring Tool uses and only works with hand-built courses.

The last reference to its use I can find is [email protected]/theme.json.
It has since been removed from v5 vanilla. The vanilla config.json:screenSize variable is now configured in src/core/schema/config.model.schema.

@brian-learningpool
Copy link
Member

I have no objections to it going.

@moloko
Copy link
Contributor

moloko commented Feb 26, 2020

None from me either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants