Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigationView should be catching DOM events and calling the relevant APIs #2669

Closed
moloko opened this issue Mar 2, 2020 · 2 comments · Fixed by #2708
Closed

navigationView should be catching DOM events and calling the relevant APIs #2669

moloko opened this issue Mar 2, 2020 · 2 comments · Fixed by #2708
Assignees
@moloko

Comments

@moloko
Copy link
Contributor

moloko commented Mar 2, 2020

a mentioned here, these sorts of events from the DOM should be handled by navigationView which then calls the relevant API
@moloko moloko self-assigned this Mar 2, 2020
@moloko moloko changed the title navigationView should be catching DOM events and calling the revelevant APIs navigationView should be catching DOM events and calling the relevant APIs Mar 6, 2020
@moloko
Copy link
Contributor Author

moloko commented Mar 6, 2020

going to park this for the moment as currently there's no public API for some of the key functions that navigationView would need to call (navigateToHomeRoute, navigateToPreviousRoute etc)

@oliverfoster oliverfoster mentioned this issue Mar 6, 2020
Closed
@oliverfoster
Copy link
Member

This should be ready to go now @moloko

@oliverfoster oliverfoster mentioned this issue Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moloko moloko

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@moloko @oliverfoster