Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript grunt task does not exit properly on error #3123

Closed
tomgreenfield opened this issue Apr 13, 2021 · 0 comments · Fixed by #3124
Closed

JavaScript grunt task does not exit properly on error #3123

tomgreenfield opened this issue Apr 13, 2021 · 0 comments · Fixed by #3124
Assignees
@tomgreenfield
Labels
bug

Comments

@tomgreenfield
Copy link
Contributor

Subject of the issue/enhancement/features

This causes the dev task to be unable to restart on a watch.

Your environment

  • Framework 5.12.2

Steps to reproduce

  1. grunt dev
  2. Deliberately introduce a syntax error in the JavaScript and save
  3. Fix syntax error and save

Expected behaviour

Build restarts when syntax error has been fixed.

Actual behaviour

Grunt task hangs because asynchronous task hasn't been marked as done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomgreenfield tomgreenfield

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix JavaScript Grunt task adaptlearning/adapt_framework
1 participant
@tomgreenfield