issue-1519: default disable a11y on touch devices

[oliverfoster]

fixes #1519

[moloko]

I've nothing whatsoever against the general concept of doing this; my only concern is that it means authors will have to set "_isDisabledOnTouchDevices": false in order to turn on accessibility which seems a little graceless to me... maybe just me though, anyone else have thoughts?

[andrewhosgood]

Why not reverse the whole logic? Rather than _isDisabledOnTouchDevices (default true), perhaps _isEnabledOnTouchDevices (default false).

if (!Modernizr.touch || this.isActive() || Adapt.config.get("_accessibility")._isEnabledOnTouchDevices !== true) return;

[oliverfoster]

That's fine if we can isolate which schemas need changing for the AT.

[oliverfoster]

@brian-learningpool @taylortom @tomgreenfield any ideas where the config._accessibility._isDisabledOnTouchDevices schema entry lives?

we want to change it to _isEnabledOnTouchDevices

[dancgray]

@oliverfoster it's in the plugins/content/config/model.schema

[oliverfoster]

much obliged sir

[oliverfoster]

just need an AT issue + PR.

[tomgreenfield]

How to do all this without a breaking change...

[oliverfoster]

what?

[NayanKhedkar]

hi @oliverfoster

adapt_framework/src/core/js/accessibility.js

Line 279 in aa5ec0c

var isEnabledOnTouchDevices = config._isEnabledOnTouchDevices || (config._isDisabledOnTouchDevices === false);

[NayanKhedkar]

|| (config._isDisabledOnTouchDevices === false); is there any need to have this ??

[oliverfoster]

Old courses which don't support _isEnabledOnTouchDevices but which do have _isDisabledOnTouchDevices set to false will still work as expected.