Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require authentication according to VTM GO TOS #141

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Conversation

michaelarnauts
Copy link
Collaborator

@michaelarnauts michaelarnauts commented Feb 22, 2020

According to the Terms of Service of VTM GO, it is required to login. Their API doesn't enforce this, but we should do this since we want to be a good citizen :)

@michaelarnauts michaelarnauts added the enhancement New feature or request label Feb 22, 2020
@codecov
Copy link

codecov bot commented Feb 22, 2020

Codecov Report

Merging #141 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   80.21%   80.34%   +0.13%     
==========================================
  Files          23       23              
  Lines        2365     2371       +6     
==========================================
+ Hits         1897     1905       +8     
+ Misses        468      466       -2     
Impacted Files Coverage Δ
resources/lib/modules/menu.py 90.24% <0.00%> (-2.44%) ⬇️
resources/lib/vtmgo/vtmgo.py 78.24% <0.00%> (-0.54%) ⬇️
resources/lib/vtmgo/vtmgostream.py 82.82% <0.00%> (+2.02%) ⬆️
resources/lib/modules/player.py 92.75% <0.00%> (+11.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa01980...3a7e9bf. Read the comment docs.

@michaelarnauts michaelarnauts merged commit 38fa000 into master Feb 22, 2020
@michaelarnauts michaelarnauts deleted the require-auth branch February 22, 2020 21:29
@dagwieers dagwieers added this to the v0.9.5 milestone Mar 3, 2020
@michaelarnauts michaelarnauts modified the milestones: v0.9.5, v1.0.0 Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants