Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make authentication more robust #192

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Make authentication more robust #192

merged 4 commits into from
Jul 22, 2020

Conversation

michaelarnauts
Copy link
Collaborator

@michaelarnauts michaelarnauts commented Jul 22, 2020 •
edited
Loading

  • Retry request with a new token when authentication has failed. It seems the tokens are valid for a long time, but there was no code to handle the case when it would finally be invalid. It might happen after a year, not sure. The actual JWT is only valid for one day, but it seems expired JWT tokens are still accepted by VTM GO.
  • Reuse request.session object
  • Make sure the path exists to store the token
  • Small cleanups

@michaelarnauts michaelarnauts changed the title Apply authentication fixes and retry when token is invalid Make authentication more robust Jul 22, 2020
@michaelarnauts michaelarnauts added the enhancement New feature or request label Jul 22, 2020
@michaelarnauts michaelarnauts merged commit d469913 into master Jul 22, 2020
@michaelarnauts michaelarnauts deleted the authentication-fixes branch July 22, 2020 19:40
@dagwieers dagwieers added this to the v1.1.0 milestone Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelarnauts @dagwieers