Assorted list of improvements #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelarnauts
requested changes
Jul 10, 2019
This PR includes: - An all programs listing - Sort programs for the default view - Reorder the main menu a bit - Return up to 50 search results - Add season and episode information to program infoLabels - Add season cover using random episode cover - Add more sorting methods to views - Replace poster with thumb (because the format is not a poster) - Add fanart to season and episodes (and add as banner) - If only one season, don't show seasons - Add lots of infoLabels
|
@michaelarnauts I propose you merge this as-is and then you experiment with the sort methods. Because that is what I did last night (again) to see if there was a better way to do this. |
|
Please don't force push, since now I have no way of seeing the changes since last review. I squash anyway, so the history is clean. |
|
This looks nice except the last remark. :) |
|
Fix and merge, or merge and fix. I am fine with whatever you prefer. |
|
It took me a while to find out how to make changes before the merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
This fixes #18