Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EPG #210

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Fix EPG #210

merged 1 commit into from
Oct 2, 2020

Conversation

mediaminister
Copy link
Contributor

This fixes #209

@michaelarnauts
Copy link
Collaborator

Thanks! One small improvement though.

I think it's better to do the call to the privacygate-confirm only once in the constructor, and remove the cookie.set that we do now. Or maybe better only do this once during the first get request, and keep an cookie_accepted var or something do we know we don't have to make that extra call.

This way, when fetching the EPG data for IPTV Manager (we do multiple requests for every date) so we don't do a call to the privacygate-confirm on every API call then (actually doubling the amount of HTTP requests, since we have to follow the redirect every time).

@mediaminister
Copy link
Contributor Author

mediaminister commented Oct 2, 2020

It turned out passing an empty authId cookie is enough.

@michaelarnauts
Copy link
Collaborator

Ow, that's nice! 👍

@michaelarnauts michaelarnauts merged commit 024b693 into add-ons:master Oct 2, 2020
@michaelarnauts michaelarnauts added the bug Something isn't working label Oct 2, 2020
@michaelarnauts michaelarnauts added this to the v1.1.3 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TV Guide doesn't work anymore
2 participants