Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hedgedoc): customize liveness and readiness probes #1320

Merged
merged 1 commit into from
Sep 16, 2024
Merged

feat(hedgedoc): customize liveness and readiness probes #1320

merged 1 commit into from
Sep 16, 2024

Conversation

jon4hz
Copy link
Member

@jon4hz jon4hz commented Sep 16, 2024 •
edited
Loading

Description

This PR adds an option to customize the liveness and readiness probes in the hedgedoc chart.

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 16, 2024
@jon4hz jon4hz force-pushed the feat-hedgedoc-probes branch 2 times, most recently from cd2f78b to ffca745 Compare September 16, 2024 13:15
@jon4hz jon4hz marked this pull request as ready for review September 16, 2024 13:26
gianklug
gianklug approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@gianklug gianklug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jon4hz jon4hz merged commit 28a30f7 into main Sep 16, 2024
3 checks passed
@jon4hz jon4hz deleted the feat-hedgedoc-probes branch September 16, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianklug gianklug gianklug approved these changes

@altesockensuppe altesockensuppe Awaiting requested review from altesockensuppe altesockensuppe is a code owner

@isantospardo isantospardo Awaiting requested review from isantospardo isantospardo is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jon4hz @gianklug