Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashed in iOS - wrong sdkVersionChar variable in ADJPackageBuilder.m #140

Closed
ridvanaltun opened this issue Aug 17, 2021 · 3 comments
Closed

Comments

@ridvanaltun
Copy link

ridvanaltun commented Aug 17, 2021

Hey,

I compiled the iOS application successfully, but the application crashes when opening. I don't know the Objective C language, but as far as I can tell, a variable named sdkVersionChar in the ADJPackageBuilder.m file is set incorrectly, so the strncpy function throws an error. You can see what I mean by looking at the xcode debug screenshot below.

react-native-adjust version: 4.29.3

Screen Shot 2021-08-17 at 16 36 05

By the way I resolved this issue changing sdkVersion variable definition like below in 310's line but i don't know can it break something else:

// old
sdkVersion[21];

// new
sdkVersion[50];
@uerceg
Copy link
Contributor

uerceg commented Aug 17, 2021

Hi @ridvanaltun

Thanks for reporting this and for the detailed explanation. We'll try to address this as soon as we can (natively + update React Native SDK as well). Will keep you posted.

This was referenced Aug 20, 2021
@uerceg
Copy link
Contributor

uerceg commented Aug 20, 2021

Hi @ridvanaltun

We have just released v4.29.4 update which should hopefully address this issue. Feel free to give it a shot and let us know if it fixed the issue you were facing with or is it still present.

Looking forward to hearing back from you.

@ridvanaltun
Copy link
Author

Hi @ridvanaltun

We have just released v4.29.4 update which should hopefully address this issue. Feel free to give it a shot and let us know if it fixed the issue you were facing with or is it still present.

Looking forward to hearing back from you.

Works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants