Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern data not accurate after translating shape #331

Open
shalanah opened this issue Jan 22, 2016 · 2 comments
Open

Pattern data not accurate after translating shape #331

shalanah opened this issue Jan 22, 2016 · 2 comments
Assignees

Comments

@shalanah
Copy link

First off, love generator-core. It has been awesome and fun to use!

When trying to recreate patterns based on the JSON data, I found a bug.

I found that the phase stays the same even if an shape is translated and moved to another place on the canvas while the pattern is "Linked with Layer" (a photoshop default). There is no way to know from the JSON that the shape has moved, and that the phase is based on the initial position of the shape and not the current, giving us inaccurate pattern data.

Would love to see this fixed by changing the phase to reflect the movement of the shape or provide the initial position of the shape so we can change the phase based on that.

Thank you for your help and consideration!

pattern_phase_translation_error

@timothynoel timothynoel self-assigned this Feb 17, 2016
@timothynoel
Copy link

All the extra params (scale/align w/layer, phase) are readily available within Photoshop, we are just getting the non-verbose version. Should be easy to address.

@chadrolfs
Copy link
Contributor

(stale) Is this still an issue? @pineapplespatula when you have a spare sec, please take a look. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants