Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placed JPG smartObject can't generate retina. #395

Open
zimag opened this issue Jul 25, 2017 · 3 comments
Open

Placed JPG smartObject can't generate retina. #395

zimag opened this issue Jul 25, 2017 · 3 comments

Comments

@zimag
Copy link

zimag commented Jul 25, 2017

If I just drag and drop a .jpg to the doc ( becoming a smartObject ) and trying to generate high res assets from it, seems like the resolution is still 72dpi.

image

If I open the .jpg first, select all pixels, copy-paste them into the original doc, and make a smartObject from it, the asset generating perfectly.

The obvious difference between the 2 smartObjects is that the .jpg one has a background layer.

Cannot_Generate_Retina_300x250_GEMIUS.zip

@canoztokmak
Copy link
Contributor

jpg is not a vector format.. so you cannot expect it to be retina even after you convert it to smart object..

@zimag
Copy link
Author

zimag commented Sep 27, 2017

Sorry if I wasn't clear enough:

The smartObject has the resolution, much more than necessary. The placed .jpg is converted to smartObject and scaled down to accomodate it's small place in the layout.

After that, if I generate a .png file, or getting a 2x resolution pixmap from this smartObject, the result isn't retina as we can see on the screenshot above. The pixels from the preview information are scaled up to the desired resolution, not the real pixel content.

If I convert the content of the smartObject to a transparent layer ( not Background ) the bug is disappearing.

@timothynoel
Copy link

timothynoel commented Sep 27, 2017

For the time being, only psd smart objects can be re-rendered as part of assert generation, and therefore take advantage of the original resolution in the underlying file. A JPEG smartobject is scaled from the existing layer data (so it's limited to what's in the layer data), a psd smart object, which is what you get with the copy/paste is re-opened/rendered so it can scale from the original pixels. This has to do with some limitations in background processing. The upshot is, if you want max resolution in your smart objects w/your assets, use PSDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants