Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test workflow updates #167

Merged
merged 22 commits into from
Oct 14, 2024

Conversation

timkimadobe
Copy link
Contributor

@timkimadobe timkimadobe commented Oct 4, 2024

Description

This PR overhauls the integration test workflow with the following changes:

  1. Use Linux runner instead of macOS (the Android emulator action reactivecircus/android-emulator-runner does not currently support M1 machines: Emulator failed to boot ReactiveCircus/android-emulator-runner#324 (comment))
  2. Add caching for both Gradle and Android Virtual Device (AVD) to speed up job
  3. Android emulator config
  4. Added logcat log export support through log capture and upload artifacts
  5. Updated location hint values to be more shell script friendly (ex: removing (), spaces, quotes)
  6. Added branch mistmatch warning step
    • This has gotten me too many times where the branch the workflow is based off of and the code branch being used in the test are different but goes unnoticed - this warning will not cause job failure but points this difference out in case it was not intended

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@timkimadobe timkimadobe changed the title Integration workflow updates Integration test workflow updates Oct 4, 2024
@timkimadobe timkimadobe merged commit c4caf4c into adobe:dev Oct 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants