Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACNA-1828 | Externalised the workflow #136

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

amulyakashyap09
Copy link
Contributor

Description

Linking the workflow to external file

Related Issue

ACNA-1828

Motivation and Context

It removes redundancy, centralises the workflow

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (417e1d4) 100.00% compared to head (863cc58) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #136   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          173       173           
  Branches        36        36           
=========================================
  Hits           173       173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron
Copy link
Member

shazron commented Jan 26, 2024

@amulyakashyap09 Needs required checks change in Branch protection settings.

@shazron shazron merged commit ef5aa34 into master Jan 30, 2024
7 checks passed
@shazron shazron deleted the feature/externalising-github-workflows branch January 30, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants