Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ACNA-2585 - library configuration & networking #138

Merged
merged 15 commits into from
Feb 14, 2024
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Feb 7, 2024

How Has This Been Tested?

  • npm test
  • e2e test on local storage-next server

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbda114) 100.00% compared to head (0016e70) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #138   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          165       208   +43     
  Branches        29        44   +15     
=========================================
+ Hits           165       208   +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommendations,

  • validate regions: oneOf amer, apac and emea
  • default region: amer

wdyt?

@shazron
Copy link
Member Author

shazron commented Feb 7, 2024

recommendations,

  • validate regions: oneOf amer, apac and emea
  • default region: amer

wdyt?

SGTM!

@shazron shazron changed the title WIP - ACNA-2585 - library configuration & networking feat: ACNA-2585 - library configuration & networking Feb 7, 2024
@shazron shazron marked this pull request as ready for review February 7, 2024 15:51
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! (just added one small comment regarding testing)

e2e/.env.example Outdated Show resolved Hide resolved
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue to not change the way we expose the expiration to users in the library (keep iso), wdyt?

doc/api.md Show resolved Hide resolved
doc/api.md Outdated Show resolved Hide resolved
@shazron
Copy link
Member Author

shazron commented Feb 9, 2024

I would argue to not change the way we expose the expiration to users in the library (keep iso), wdyt?

makes sense, ISO string is unambiguous, and better, I think

@shazron shazron merged commit 69417ca into master Feb 14, 2024
7 checks passed
@shazron shazron deleted the story/ACNA-2585 branch February 14, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants