showModalDialogUsingTemplate doesn't blur current editor

[zaggino]

Thought picture would be easiest:

[RaymondLim]

@zaggino Not sure why this focus issue still can be reproduced even after Reload w/o extension is invoked, but I'm sure that if you explicitly move your git extension out of the user folder, then we don't see the issue.

[lkcampbell]

@zaggino, let me know if what @RaymondLim just said is reproducible. I would be interested in seeing a case where Reload Without Extensions might be failing like that.

[marcelgerber]

@RaymondLim Nope, I can even repro it with extension moved out of user folder.
Not a fail of Reload w/o extensions.

Windows 8.1

E: I can even repro it without AppData/Brackets folder (no cache and so on). Definitely a Brackets bug.

[marcelgerber]

I can repro this back to Sprint 30, so no recent change. Notice this only happens with the Switch language dialog, where the primaryButton is disabled by default.

[RaymondLim]

@SAplayer You're right! Somehow I can't reproduce it with my earlier testing on my mac. Now I can reproduce it with no extension in my user folder.

[zaggino]

https:/adobe/brackets/blob/master/src/widgets/Dialogs.js#L306-L310

I don't think that the dialogs should rely with focus on existence of .primary button and also the whole if is wrong there because jQuery returns array even if it doesn't find anything so it should be just $dlg.find(".primary").focus();

[njx]

Low pri to me for 1.0. It's low because there probably aren't many dialogs that run into this issue, since most dialogs have an enabled primary button, but we should fix it anyway.

[peterflynn]

@njx looks like fix already in progress: PR #7677

[njx]

Nice, reassigning to @TomMalbran

[njx]

Reviewed, leaving in 1.0.

[njx]

Marking fixed but not closed to @zaggino - please confirm and close. Thanks!

[zaggino]

Confirmed fixed, closing.