Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pattern synonym in Nat.Base in the way when working with products #2250

Closed
flupe opened this issue Jan 9, 2024 · 3 comments
Closed

pattern synonym in Nat.Base in the way when working with products #2250

flupe opened this issue Jan 9, 2024 · 3 comments

Comments

@flupe
Copy link
Contributor

flupe commented Jan 9, 2024

I'm currently working in a development importing both Data.Product.Base and Data.Nat.Base.

Every time I have a hole of type Σ A B and I refine said hole, the following pattern gets introduced: less-than-or-equal {?} ? instead of ? , ?. This stems from a pattern-synonym recently introduced in Nat.Base: https:/agda/agda-stdlib/blame/3515c22f3a2c1bd2eeb5fdd504072f67aab3de4d/src/Data/Nat/Base.agda#L366

Am I doing something wrong? Or maybe this pattern-synonym should not stay in Nat.Base?

To reproduce, just try to refine the hole in the following code sample:

open import Data.Unit.Base
open import Data.Nat.Base
open import Data.Product.Base

t : ⊤ × ⊤
t = {!!}
@flupe
Copy link
Contributor Author

flupe commented Jan 9, 2024

My bad, duplicate of #2216, known issue. Closing.
The takeaway seem to be not to open import Nat.Base.

@flupe flupe closed this as completed Jan 9, 2024
@jamesmckinna jamesmckinna reopened this Jan 14, 2024
@jamesmckinna
Copy link
Contributor

jamesmckinna commented Jan 14, 2024

The takeaway is that the issue should even have been fixed now in v2.0 (your example with C-c C-r in the hole yields ? , ? as to be expected), so please consider yourself encouraged to migrate to that release as soon as possible. But if you still have a problem with v2.0, please let us know, either by re-opening this issue, or by opening a fresh one (better).

@flupe
Copy link
Contributor Author

flupe commented Jan 23, 2024

Ah, I didn't even think about checking whether I was using the latest version. Sorry for the trouble and thank you for fixing the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants