Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Function.Endomorphism.* to avoid use of deprecated Function.Equality #2299

Closed
2 tasks done
jamesmckinna opened this issue Feb 23, 2024 · 3 comments · Fixed by #2342
Closed
2 tasks done

Update Function.Endomorphism.* to avoid use of deprecated Function.Equality #2299

jamesmckinna opened this issue Feb 23, 2024 · 3 comments · Fixed by #2342

Comments

@jamesmckinna
Copy link
Contributor

jamesmckinna commented Feb 23, 2024

The #759 deprecation effort left some residues which still import (at least) Function.Equality (with a pragma to suppress the warning), notably:

  • Function.Endomorphism.Setoid
  • Function.Endomorphism.Propositional

which define the monoid etc. of endomorphisms (needed for a development of Foldable cf. generalising #1281 , and also now #2350 ).

UPDATED: blocked on not-yet-merged #2240 each of the above also uses the long-since-deprecated (v1.5!) Algebra.Morphism.Is*Morphism definitions instead of updating to the ones in Algebra.Morphism.Structures ...

Should update to remove dependency on the deprecated module(s).

@JacquesCarette
Copy link
Contributor

Unfortunately the PR itself is regarded as a breaking change (even though not doing this for v2.0 was an oversight), so this issue should also get that label.

@jamesmckinna
Copy link
Contributor Author

So the non-breaking suggestion on #2342 would be (instead) to introduce Function.Endo.* as new modules, and deprecate the Function.Endomorphism.* modules...?

@JacquesCarette
Copy link
Contributor

Yes, I think that that name makes more sense than .New. I'll implement that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants