Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRY] More redundant zero fields in Algebra.Structures #2396

Open
jamesmckinna opened this issue May 27, 2024 · 0 comments
Open

[DRY] More redundant zero fields in Algebra.Structures #2396

jamesmckinna opened this issue May 27, 2024 · 0 comments
Labels
addition breaking bug

Comments

@jamesmckinna
Copy link
Contributor

jamesmckinna commented May 27, 2024 •
edited
Loading

Cf. #2195 and #2253

  • IsNonAssociativeRing admits enough properties to make the zero field redundant by exactly the same argument as for IsRingWithoutOne (so the redundancy is a bug, and removing it would be breaking)
  • correspondingly, the argument for IsRingWithoutOne makes no use of *-assoc...

Possible remedy: introduce a further refinement in which a new IsNonAssociativeRingWithoutOne would the 'right' home for such an argument, with each of the above two structures inheriting from that...?

See for example this blob and prior refactoring via Quasiring... for a possible solution.
lexvanderstoep pushed a commit to lexvanderstoep/agda-stdlib that referenced this issue Jun 16, 2024
Fix agda#2396 by removing redundant zero in IsNonAssociativeRing
4fdac7b 
The zero field in the IsNonAssociativeRing was redundant, and could
be replaced with a proof based on the other properties.
lexvanderstoep added a commit to lexvanderstoep/agda-stdlib that referenced this issue Jun 16, 2024
@lexvanderstoep
Fix agda#2396 by removing redundant zero in IsNonAssociativeRing
12493b4 
The zero field in the IsNonAssociativeRing was redundant, and could
be replaced with a proof based on the other properties.
lexvanderstoep added a commit to lexvanderstoep/agda-stdlib that referenced this issue Jun 16, 2024
@lexvanderstoep
Fix agda#2396 by removing redundant zero in IsNonAssociativeRing
66b5974 
The zero field in the IsNonAssociativeRing was redundant, and could
be replaced with a proof based on the other properties.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addition breaking bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamesmckinna