Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Pointed algebraic structure, (raw) bundle and homomorphism #1958

Closed
wants to merge 2 commits into from

Conversation

jamesmckinna
Copy link
Contributor

@jamesmckinna jamesmckinna commented Apr 29, 2023

See issue #1957

TODOs:

@jamesmckinna
Copy link
Contributor Author

jamesmckinna commented Apr 29, 2023

Hmmm... the library disagrees with @JacquesCarette 's analysis that Pointed belongs under Algebra:

module Relation.Nullary.Construct.Add.Point where

open import Data.Maybe.Base public
  using () renaming (Maybe to Pointed; nothing to ∙; just to [_])

Maybe this PR isn't required after all? Or at least, in a way which is suitably/sensibly (backwards) compatible.

UPDATED: and with apologies for insufficient testing before issuing the PR :-(

@jamesmckinna jamesmckinna marked this pull request as draft May 1, 2023 18:32
@jamesmckinna jamesmckinna added status: blocked-by-issue Progress on this issue or PR is blocked by another issue. and removed status: being-worked-on labels May 1, 2023
@JacquesCarette
Copy link
Contributor

See my comments on #1957 .

There's a difference between the theory and the free algebra associated to it. I meant the theory, which belongs in Algebra. The data structure belong in Data. That the construction lives under Relation is fine, but Relation.Nullary is an aberration. What's the use of a relation on nothing?

@jamesmckinna
Copy link
Contributor Author

As with #1963 I'm going to close this for now, pending (the design of) a resolution of #1957, at which point this PR might be the (best?) place to implement such a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants