Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put indexed data types in the right universes #2030

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented Jul 24, 2023

Base #2028 on master instead of on outdated experimental.

@plt-amy writes:
To fix agda/agda#6654, we've decided that large indices will no longer be allowed by default.
There is an infective flag --large-indices to bring them back, but none of the uses of large indices in the standard library were essential: to avoid complicated mutually-recursive PRs across repos, I adjusted the levels to check with --no-large-indices instead of adding the flag to the modules that used them.

To fix agda/agda#6654, we've decided that large indices will no longer
be allowed by default. There is an infective flag `--large-indices` to
bring them back, but none of the uses of large indices in the standard
library were essential: to avoid complicated mutually-recursive PRs
across repos, I adjusted the levels to check with `--no-large-indices`
instead of adding the flag to the modules that used them.
@andreasabel andreasabel changed the base branch from master to aliao/large-indices July 24, 2023 14:06
@andreasabel andreasabel changed the base branch from aliao/large-indices to master July 24, 2023 14:06
@andreasabel andreasabel added this to the Agda-2.6.4 milestone Jul 24, 2023
@andreasabel andreasabel changed the title large indices Put indexed data types in the right universes Jul 24, 2023
@andreasabel
Copy link
Member Author

Added a CHANGELOG entry (and fixed whitespace violations there).

@andreasabel
Copy link
Member Author

I suppose the stdlib tsars are on vacation/busy atm. To clear the road for an Agda 2.6.4 RC, I am merging this now. These are anyhow mild changes...

@andreasabel andreasabel merged commit 026ef1a into master Jul 25, 2023
1 check passed
@JacquesCarette
Copy link
Contributor

It would be nice indeed to not have a bottleneck of a single person who merges PRs. I've discussed a bit with @jamesmckinna who has also talked w/ @MatthewDaggitt about it, but I don't think it has gone beyond that. [I don't really want that power myself! I just would like the process to be a little faster without putting undue pressure onto a single person.]

@jespercockx
Copy link
Member

Well there is more than one person with the power to merge PRs here (as Andreas just demonstrated). It is just a power that's rarely exercised.

@JacquesCarette
Copy link
Contributor

AFAIK, I have the power too - but I'd like to know when I (and others) should use it. I think @andreasabel did the right thing, BTW.

@Taneb
Copy link
Member

Taneb commented Jul 25, 2023

@JacquesCarette do you want to start a thread to discuss this on Zulip?

@JacquesCarette
Copy link
Contributor

I think I'm going to wait until the most active people seem to be back online - but yes, good idea.

@andreasabel andreasabel mentioned this pull request Aug 27, 2023
@andreasabel andreasabel mentioned this pull request Oct 10, 2023
4 tasks
andreasabel added a commit to andreasabel/agda-stdlib that referenced this pull request Oct 10, 2023
MatthewDaggitt pushed a commit that referenced this pull request Oct 13, 2023
@MatthewDaggitt MatthewDaggitt removed this from the Agda-2.6.4 milestone Oct 15, 2023
@MatthewDaggitt MatthewDaggitt added this to the v1.7.3 milestone Oct 15, 2023
@MatthewDaggitt MatthewDaggitt deleted the large-indices branch October 16, 2023 23:41
andreasabel added a commit that referenced this pull request Jul 10, 2024
@andreasabel andreasabel mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forcing analysis is inconsistent for large indices
6 participants