Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nagata's "idealization of a module" construction #2244

Merged
merged 24 commits into from
Feb 25, 2024
Merged

Nagata's "idealization of a module" construction #2244

merged 24 commits into from
Feb 25, 2024

Commits on Jan 3, 2024

  1. Nagata's construction

    @jamesmckinna
    jamesmckinna committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    c05e202 View commit details
    Browse the repository at this point in the history

  2. removed redundant zero

    @jamesmckinna
    jamesmckinna committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    f4ebde8 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. first round of Jacques' review comments

    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    9618484 View commit details
    Browse the repository at this point in the history

  2. proved the additional properties

    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    934b275 View commit details
    Browse the repository at this point in the history

  3. some of Matthew's suggestions, plus more vertical whitespace, less ho… 

    …rizontal; more comments
    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    7db0e4d View commit details
    Browse the repository at this point in the history

  4. Matthew's suggestion: using private modules

    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    fdb7ab1 View commit details
    Browse the repository at this point in the history

  5. Matthew's suggestion: lifting out left-/right- sublemmas

    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    2fd0ef7 View commit details
    Browse the repository at this point in the history

  6. standardised names, as far as possible

    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    283d9c6 View commit details
    Browse the repository at this point in the history

  7. Matthew's suggestion: lifting out left-/right- sublemmas

    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    42f9da2 View commit details
    Browse the repository at this point in the history

  8. fixed constraint problem with ambiguous symbol; renamed ideal lemmas

    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    fdb8bfb View commit details
    Browse the repository at this point in the history

  9. renamed module

    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e11bbc8 View commit details
    Browse the repository at this point in the history

  10. renamed module in CHANGELOG

    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    6935d8a View commit details
    Browse the repository at this point in the history

  11. added generalised annihilation lemma

    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ae2d7f1 View commit details
    Browse the repository at this point in the history

  12. typos

    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    d4621a4 View commit details
    Browse the repository at this point in the history

  13. use correct rexported names

    @jamesmckinna
    jamesmckinna committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    afd70a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. now as a paramterised module instead

    @jamesmckinna
    jamesmckinna committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    03ce179 View commit details
    Browse the repository at this point in the history

  2. or did you intend this?

    @jamesmckinna
    jamesmckinna committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    583a712 View commit details
    Browse the repository at this point in the history

  3. fix whitespace

    @jamesmckinna
    jamesmckinna committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    c859f58 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. aligned one step of reasoning

    @jamesmckinna
    jamesmckinna committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    ab91b55 View commit details
    Browse the repository at this point in the history

  2. more re-alignment of reasoning steps

    @jamesmckinna
    jamesmckinna committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    31ff3c1 View commit details
    Browse the repository at this point in the history

  3. more re-alignment of reasoning steps

    @jamesmckinna
    jamesmckinna committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    a19c784 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Merge branch 'master' into nagata

    @jamesmckinna
    jamesmckinna authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    174c706 View commit details
    Browse the repository at this point in the history

  2. Matthew's review comments

    @jamesmckinna
    jamesmckinna committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    fe8d2a3 View commit details
    Browse the repository at this point in the history

  3. blanklines

    @jamesmckinna
    jamesmckinna committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    80f30c9 View commit details
    Browse the repository at this point in the history