Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: more permissive mst peerDep, update mst devDep #33

Merged
merged 5 commits into from
Jul 13, 2023
Merged

deps: more permissive mst peerDep, update mst devDep #33

merged 5 commits into from
Jul 13, 2023

Conversation

barbalex
Copy link
Contributor

@barbalex barbalex commented Jul 12, 2023 •
edited by agilgur5
Loading

resolves #32

@agilgur5 agilgur5 changed the title Fix upstream dependency conflict Update mst peerDep Jul 13, 2023
agilgur5
agilgur5 requested changes Jul 13, 2023
View reviewed changes
Copy link
Owner

@agilgur5 agilgur5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were able to test and confirm that this was working on MST 5, right? Seems like there weren't too many changes in 4.0.0 or 5.0.0 thankfully

The CI on this repo is still on Travis, so I need to migrate that to GH Actions to get it to run on each PR

package.json Outdated Show resolved Hide resolved
agilgur5
agilgur5 reviewed Jul 13, 2023
View reviewed changes
Copy link
Owner

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the devDeps as well to make sure MST 5 is tested against. That'll require an update of the MobX devDep as well

@agilgur5
Copy link
Owner

The CI on this repo is still on Travis, so I need to migrate that to GH Actions to get it to run on each PR

CI has been migrated as of #34 now. If you rebase off main, that should get it to run on your PR

@agilgur5 agilgur5 changed the title Update mst peerDep deps: update mst peerDep Jul 13, 2023
@barbalex
Copy link
Contributor Author

You were able to test and confirm that this was working on MST 5, right?

Yes, in two of my projects it has been running flawlessly for years

@barbalex
Copy link
Contributor Author

Not sure if I did all that's needed. Please check

barbalex and others added 3 commits July 13, 2023 12:32
@agilgur5 agilgur5 closed this Jul 13, 2023
@agilgur5 agilgur5 reopened this Jul 13, 2023
@agilgur5
ci: run on PR as well
c890d14 
- I thought `push` covered PRs as well, maybe that got changed
  - or it was always only for my own PRs? not sure as it worked in repos I don't own either...
@agilgur5 agilgur5 changed the title deps: update mst peerDep deps: more permissive mst peerDep, update mst devDep Jul 13, 2023
@agilgur5
ci: add skipLibCheck to typecheck
ac13264 
- was getting errors on MST and MobX internal types
  - current TS direction is to use `skipLibCheck` as the default
    - c.f. microsoft/TypeScript-Website@625e1c5
agilgur5
agilgur5 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Owner

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated devDeps myself, LGTM now! all tests still passing 🙂

also had to update some one-line CI settings

@codecov

This comment was marked as resolved.

Sign in to view
@agilgur5 agilgur5 merged commit 7a6e8e0 into agilgur5:main Jul 13, 2023
14 checks passed
@agilgur5
Copy link
Owner

Released in 0.1.4.

Thanks for your continued contribution @barbalex!

@agilgur5 agilgur5 added the scope: dependencies Pull requests that update a dependency file label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees
No one assigned
Labels
scope: dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mst peerDep is outdated
2 participants
@barbalex @agilgur5