-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limiting the request size #113
Comments
(Changed the title because initially I thought requestSizeCheck was the problem) |
The size check will be executed when the body is actually consumed and that's when the exception will trigger. It seems that you are correct that the exception will never be thrown at the line you mentioned. This was the case before as we already parsed the body there strictly before actually needing it. I guess one could remove the handler there. |
requestSizeCheck modifies a request to embed size-checking inside the
responseBody
instead of performing the check immediately. (And I presume this is on purpose.)My concern is the error handling suggests that the exception could be thrown at this line in
handleRequest'
but I don't thinkmakeActionEnvironment
forces the evaluation of the request body either. If it does though, thengetErrorHandler config status413
is fed intorespStateToResponse
, which throw an error.Thoughts?
The text was updated successfully, but these errors were encountered: