-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not match uppercasing of enum keys of protoc #25
Comments
Just merged, and latest version 2.3.1 has been published. Thank you for your issue & pr. |
Thank you for the timely review and publish! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
grpc_tools_node_protoc automatically uppercases enum keys, whereas grpc_tools_node_protoc_ts maintains whatever casing is in the proto file. The mismatch causes typescript errors when using the javascript enum correctly.
Example repo here: https:/TLadd/example-grpc-enum.
Proto file: https:/TLadd/example-grpc-enum/blob/master/helloworld.proto#L32
Generated js: https:/TLadd/example-grpc-enum/blob/master/helloworld_pb.js#L160
Generated ts:
https:/TLadd/example-grpc-enum/blob/master/helloworld_pb.d.ts#L33
The text was updated successfully, but these errors were encountered: