Use custom as dark mode #1023
Closed
Use custom as dark mode #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove unused code - correctly indent the code with 4 spaces.
Automatically toggle between dark and light mode depending on the desired mode from the operating system. Introduces a new config option `use_system_theme` which if set automatically set light or dark mode when starting depending on if the current operating system theme is in light or dark mode. Then, if the operating system mode changes, the change is reflected in Sioyek.
A new configuration option `use_custom_as_dark` which if set uses the custom color mode as dark mode.
|
Thanks, however, I think modifying the behavior of dark mode is a little confusing, so instead I added a |
|
That's a good solution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Yet another PR from me :-).
Again, this can be stacked with #1021 and #1022.
The change introduces a configuration option which I've called
use_custom_as_darkwhich treatstoggle_dark_modeastoggle_custom_color. It plays really nicely with #1022 to allow the operating system to toggle light/dark mode but the user can configure the colors of the dark mode.