Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot aren't help with the releases. #18

Closed
harshad16 opened this issue Jan 8, 2021 · 3 comments
Closed

Bot aren't help with the releases. #18

harshad16 opened this issue Jan 8, 2021 · 3 comments
Assignees

Comments

@harshad16
Copy link
Contributor

Describe the bug
The Thoth Bot which helps with releases is somehow not responding to the request made by the maintainer.

To Reproduce
create any release issue with maintainer privilege

Expected behavior
successfully create a changelog, tag, and an image in quay.

Additional context
#16 #15

@harshad16
Copy link
Contributor Author

harshad16 commented Jan 8, 2021

During the release of an application with help of thoth bots, involves kebechet and aicoe-ci bot application, which works together to release the application.
kebechet function to update the version string based on release type major/minor/patch and create a changelog w.r.t to the previous version tag available.
aicoe-ci once a new tag is available, aicoe-ci creates a build based on the details described in the configuration file.

The new major release issue was stuck because kebechet was trying to update the version string and create a changelog.
During the creation of the changelog, it looked for a previous version tag, as there was no version tag. It started to accumulate all logs from the beginning. The process was blocked, as kebechet function of getting the log, errored out with a fatal issue of unknown revision.

Error message:

  cmdline: git log --format=%s --no-merges c71cd82c2339a7b675d7caca79a4a47c4c68a64b
601b8f897354a47470a893a84043fada54c28c9f..HEAD
  stderr: 'fatal: ambiguous argument 'c71cd82c2339a7b675d7caca79a4a47c4c68a64b
601b8f897354a47470a893a84043fada54c28c9f..HEAD': unknown revision or path not in the working tree.

there seems to be some commit issue in the git tree. More investigation is required to actually resolve this git tree unknow commit revision issue.

However, if the maintainer is satisfied with a small changelog, then the hack to resolve this issue to create a previous minor tag
on an older commit, which in turn would help kebechet create a small changelog and not looking over the whole git tree but a subset.

This approach was used and @tumido created a minor tag with an older commit. https:/aicoe-aiops/mailing-list-analysis-toolkit/releases/tag/v0.1.0

The release is fixed with this fix, #21
#16

@tumido
Copy link
Member

tumido commented Jan 8, 2021

Thank you @harshad16 for you time and brainpower on this! 🥇 It is very appreciated! 🚀

The git tree issue comes from merging the template repo changes for the first time while not having a previous release it seems.

Kebechet resolved 2 repository root commits - c71cd82 (from this repo) and 601b8f8 (from the template). Which lead to the incorrect command executed by Kebechet:

git log --format=%s --no-merges c71cd82c2339a7b675d7caca79a4a47c4c68a64b 601b8f897354a47470a893a84043fada54c28c9f..HEAD

only one commit range is allowed in git log, Kebechet tried to fetch 2. Probably some variable expansion gone wrong.

@tumido
Copy link
Member

tumido commented Jan 12, 2021

This issue was resolved via a workaround and bots are helping on release of this repo again. I'm closing this issue now, appropriate bug reports should be tagged with this issue already so the great explanation and root cause documentation doesn't get lost. 🙂

@tumido tumido closed this as completed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants