verify_ssl for aiohttp.request

[wabu]

I did not find a way to pass verify_ssl to aiohttp.request. It somehow seems implemented in ClientRequest and TCPConnector, but it is not passed on in aiohttp.request.

A workaround for now is to pass connector=aiohttp.TCPConnector(force_close=True, verify_ssl=False), but it's not very usable.

[fafhrd91]

passing connector is proper way of passing verify_ssl, if we add verify_ssl to aiohttp.request() it'd add ambiguity with connector parameter.

i am -1

@asvetlov what do you think?

[asvetlov]

I agree that verify_ssl should live in connector ctor.
Default behavior is verify_ssl=True, that's reasonable one.
If you need to disable ssl check please use explicit connector object.

[amfarrell]

One challenge this causes is needing to make sure that connector always gets properly closed.

[popravich]

@amfarrell, you can use connector with ClientSession and it will close the one properly.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.