Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dangling dash character in version number in docs. #2864

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Fix dangling dash character in version number in docs. #2864

merged 1 commit into from
Mar 20, 2018

Conversation

manisenkov
Copy link
Contributor

What do these changes do?

Just fix annoying dangling dash character in the index page of docs:
screen shot 2018-03-20 at 21 05 36

Are there changes in behavior for the user?

No

@manisenkov manisenkov changed the title Fix trailing dash in version number in docs. Fix dangling dash character in version number in docs. Mar 20, 2018
@kxepal
Copy link
Member

kxepal commented Mar 20, 2018

Thanks! But does tag always contains - to be delimited from the version?

@manisenkov
Copy link
Contributor Author

Actually no, current version in master written as 3.1.0a0

__version__ = '3.1.0a0'

Should tag always be separated with -?

@kxepal
Copy link
Member

kxepal commented Mar 20, 2018

a0 isn't a tag in that mean, but that version fullfils PEP-440 requirements. I'm not sure what the tag value could be there, but if it's a0, dev0 or sort of that thing, than patch is good.

@asvetlov what do you think?

@codecov-io
Copy link

codecov-io commented Mar 20, 2018

Codecov Report

Merging #2864 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2864   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files          39       39           
  Lines        7444     7444           
  Branches     1307     1307           
=======================================
  Hits         7293     7293           
  Misses         48       48           
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8ea94...08a1919. Read the comment docs.

@asvetlov
Copy link
Member

I like the change.
I've added a dash looking on pre-release docs. Released version looks confusing, agree.

Regarding to tags.
@kxepal ironically you are the author of this naming: https:/aio-libs/aiohttp/blame/master/docs/conf.py#L26-L31
I don't care too much, let's just drop a dash and that's it.

@asvetlov asvetlov merged commit 655867a into aio-libs:master Mar 20, 2018
@asvetlov
Copy link
Member

@manisenkov thanks

@kxepal
Copy link
Member

kxepal commented Mar 21, 2018

@asvetlov ahaha! Nice found, I even forgot that. Indeed a bug.

@manisenkov thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https:/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants