Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct some exceptions string format #4068

Merged
merged 1 commit into from
Sep 17, 2019
Merged

fix: correct some exceptions string format #4068

merged 1 commit into from
Sep 17, 2019

Conversation

Hanaasagi
Copy link
Member

@Hanaasagi Hanaasagi commented Sep 17, 2019 •
edited
Loading

What do these changes do?

Fix some string format.

Are there changes in behavior for the user?

No

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 17, 2019
@Hanaasagi Hanaasagi changed the title fix: string format fix: correct some exceptions string format Sep 17, 2019
asvetlov
asvetlov approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good findings, thank you very much!

@asvetlov asvetlov merged commit 5d88cb0 into aio-libs:master Sep 17, 2019
asvetlov pushed a commit that referenced this pull request Sep 17, 2019
@Hanaasagi @asvetlov
[3.6] fix: correct exceptions string format (#4068)
7169e65 
(cherry picked from commit 5d88cb0)

Co-authored-by: 秋葉 <[email protected]>
asvetlov added a commit that referenced this pull request Sep 17, 2019
@asvetlov @Hanaasagi
[3.6] fix: correct exceptions string format (#4068) (#4069)
814885f 
(cherry picked from commit 5d88cb0)

Co-authored-by: 秋葉 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hanaasagi @asvetlov