Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web_response.Response.prepared is False after write_eof() #5343

Closed
arthurdarcet opened this issue Dec 14, 2020 · 1 comment · Fixed by #5344
Closed

web_response.Response.prepared is False after write_eof() #5343

arthurdarcet opened this issue Dec 14, 2020 · 1 comment · Fixed by #5344
Labels
bug

Comments

@arthurdarcet
Copy link
Contributor

web_response.Response.prepared is False after write_eof() (the payload writer goes back to None).

This is a bit mis-leading - any reason not to change Response.prepared to self._eof_sent or self._payload_writer is not None?
@asvetlov
Copy link
Member

This is the oversight, sure.

Please feel free to make a pull request.

arthurdarcet added a commit to arthurdarcet/aiohttp that referenced this issue Dec 14, 2020
@arthurdarcet
StreamResponse.prepared returns True even after EOF is sent (fixes ai…
3c9a5d3 
…o-libs#5343)
@arthurdarcet arthurdarcet mentioned this issue Dec 14, 2020
Merged
This was referenced Aug 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix StreamResponse.prepared not returning True after EOF is sent arthurdarcet/aiohttp
2 participants
@asvetlov @arthurdarcet