-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientResponseError wrong error propagation? #662
Labels
Comments
exception handling needs some cleanup |
client does not catch ServerDisconnectedError anymore |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In the client, I believe you catch
ServerDisconnectedError
and a couple other errors and propagate asClientResponseError
with__cause__
set as the real error. I think some other place in the code, I'm getting the raw "ServerDisconnectedError". Realized this since I wasn't catching the error.Usually:
ClientResponseError
with causeServerDisconnectedError
Sometimes:
ServerDisconnectedError
with causeConnectionResetError
Is this by design?
The text was updated successfully, but these errors were encountered: