-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ValueError: verify_ssl, ssl_context, fingerprint and ssl parameters are mutually exclusive #8097
Closed
1 task done
Labels
Comments
There was code elsewhere to change it from None to True. I've just duplicated it in the merge_ssl_params() function to be safe. |
patchback bot
pushed a commit
that referenced
this issue
Jan 29, 2024
Fixes #8097. --------- Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]> (cherry picked from commit aca206f)
Dreamsorcerer
added a commit
that referenced
this issue
Jan 29, 2024
#8101) **This is a backport of PR #8098 as merged into 3.10 (aca206f).** Fixes #8097. Co-authored-by: Sam Bull <[email protected]>
Amazing, thank you @Dreamsorcerer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
This change #8043 is listed in the changelog under "features" https://docs.aiohttp.org/en/stable/changes.html#features, but I think it is a breaking change.
For example, aiobotocore creates a
TCPConnector
and passes bothverify_ssl
andssl
, and after upgrading to aiohttp 3.9.2 started to fail with aValueError
because theverify_ssl
andssl
parameters are mutually exclusive.Regardless,
aiobotocore
needs to stop using the deprecatedverify_ssl
argument (aio-libs/aiobotocore#882), but in the meantime I doubt you intended 3.9.2 to contain a breaking change in this way.To Reproduce
Expected behavior
don't raise a
ValueError
Logs/tracebacks
Python Version
aiohttp Version
multidict Version
yarl Version
OS
Ubuntu 22.04.3
Related component
Client
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: