-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on_request_headers_sent params type was never imported into the top-level file. #8946
Closed
1 task done
Labels
Comments
As you've already identified the solution, it'd be great if you could just put the fix in a PR. |
If you've said this 4 minutes earlier I'd be able to 😅 |
5 tasks
This was referenced Aug 31, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
aiohttp.tracing.TraceRequestHeadersSentParams exists in aiohttp/tracing.py, but wasn't imported into _main_.py like the other param types.
To Reproduce
file: main.py
import aiohttp
from types import SimpleNamespace
trace_config = aiohttp.TraceConfig()
async def on_request_headers_sent(session: aiohttp.ClientSession, trace_config_ctx: SimpleNamespace, params: aiohttp.TraceRequestHeadersSentParams):
...
Expected behavior
aiohttp.TraceRequestHeadersSentParams would be a valid typehint and no issues would occur.
Logs/tracebacks
Python Version
aiohttp Version
multidict Version
yarl Version
OS
macOS Monterey (12.7.6)
Related component
Client
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: