Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly return TimeoutError on WebSocketResponse.close() (#1084) #1089

Merged
merged 1 commit into from
Aug 24, 2016

Conversation

achimnol
Copy link
Member

What do these changes do?

Revises WebSocketResponse.close() patch by explicitly returning TimeoutError with close code 1006 in #1084 for #1002.

Are there changes in behavior for the user?

Nothing.

Related issue number

#1002

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@codecov-io
Copy link

codecov-io commented Aug 15, 2016

Current coverage is 97.62% (diff: 100%)

Merging #1089 into master will decrease coverage by 0.08%

@@             master      #1089   diff @@
==========================================
  Files            28         28          
  Lines          6407       6432    +25   
  Methods           0          0          
  Messages          0          0          
  Branches       1078       1094    +16   
==========================================
+ Hits           6260       6279    +19   
- Misses           80         81     +1   
- Partials         67         72     +5   

Powered by Codecov. Last update 4167156...6a07366

@@ -229,12 +230,14 @@ def handler(request):
assert 'request' == (yield from ws.receive_str())
ws.send_str('reply')
begin = ws._loop.time()
yield from ws.close()
assert True == (yield from ws.close())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just assert (yield from ws.close()) would be fine.

@achimnol
Copy link
Member Author

I have fixed the branch according to your comments and rebased!
...ough... forced push has made your comments invisible... 😢

@asvetlov asvetlov closed this Aug 24, 2016
@asvetlov asvetlov reopened this Aug 24, 2016
@asvetlov asvetlov merged commit 03ca4a3 into aio-libs:master Aug 24, 2016
@asvetlov
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants