Maybe resume read nowait

[dalazx]

What do these changes do?

FlowControlStreamReader.read_nowait was not resuming the underlaying transport in case the buffers are drained, so that the subsequent FlowControlStreamReader.read call would hang until it timed out.

read, readany and others had @maybe_resume decorator but read_nowait did not. Since read_nowait changes _buffer and _buffer_size, we need to check the new size against _buffer_limit and perform the pause/resume action accordingly.

Are there changes in behavior for the user?

Related issue number

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• Add yourself to CONTRIBUTORS.txt
• Add a new entry to CHANGES.rst
  • Choose any open position to avoid merge conflicts with other PRs.
  • Add a link to the issue you are fixing (if any) using #isuue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

[codecov-io]

Current coverage is 98.53% (diff: 100%)

Merging #1206 into 1.0 will increase coverage by 0.18%

@@                1.0      #1206   diff @@
==========================================
  Files            29         29          
  Lines          6530       6545    +15   
  Methods           0          0          
  Messages          0          0          
  Branches       1094       1095     +1   
==========================================
+ Hits           6422       6449    +27   
+ Misses           56         45    -11   
+ Partials         52         51     -1   

Powered by Codecov. Last update a6e39f2...ca5ed93

[asvetlov]

@dalazx please add a test or two for covering all affected lines.
I love to merge your PR and publish a new bugfix release but want to improve test coverage especially in complex cases like stream resuming.
My final target is 100% coverage someday.

[dalazx]

@asvetlov please take a look

[asvetlov]

Awesome!
Thanks, @dalazx !

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.