remove Application dependency from UrlDispatcher #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we need to update docs and add deprecation warning to i think |
fafhrd91
force-pushed
the
refactor-subapps
branch
from
9ce16ef
to
295e288
Compare
Current coverage is 98.69% (diff: 58.06%)@@ master #1510 diff @@
==========================================
Files 30 30
Lines 6986 7070 +84
Methods 0 0
Messages 0 0
Branches 1163 1180 +17
==========================================
+ Hits 6907 6978 +71
- Misses 39 52 +13
Partials 40 40
|
popravich
reviewed
Dec 26, 2016
| raise RuntimeError( | ||
| "Cannod add sub application to frozen application") | ||
| if subapp.frozen: | ||
| raise RuntimeError("Cannod add frozen application") |
popravich
reviewed
Dec 26, 2016
|
|
||
| def _wrap_add_subbapp(app): | ||
|
|
||
| def add_subapp(prefix, subapp): | ||
| if subapp.frozen: | ||
| raise RuntimeError("Cannod add frozen application") |
There was a problem hiding this comment.
...a-ha, copied from here — "cannod"
fafhrd91
force-pushed
the
refactor-subapps
branch
from
295e288
to
dc13304
Compare
|
@asvetlov objections? also what about |
|
Hmm. I dislike Also I doubt if it will work with all possible router implementations. I suggest keeping the code as is. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think UrlDispatcher should not depend on Application object.
Here is backward compatible change to remove this dependency.
@asvetlov