Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is not possible to send pre-chunked stream #1655

Closed
fafhrd91 opened this issue Feb 17, 2017 · 7 comments
Closed

It is not possible to send pre-chunked stream #1655

fafhrd91 opened this issue Feb 17, 2017 · 7 comments
Labels
client good first issue Good for newcomers outdated
Milestone
2.1

Comments

@fafhrd91
Copy link
Member

Client code automatically enables chunking if headers contains transfer-encoding: chunked
So it is not possible to implement custom chunking encoding or send pre-chunked stream
@fafhrd91 fafhrd91 changed the title It is not possible to send pre-chunked request It is not possible to send pre-chunked stream Feb 17, 2017
@fafhrd91 fafhrd91 added this to the 2.1 milestone Feb 17, 2017
@fafhrd91 fafhrd91 added client good first issue Good for newcomers labels Feb 17, 2017
@fafhrd91
Copy link
Member Author

If chunked enabled, content-length and transfer-encoding in headers should be forbidden

@fafhrd91
Copy link
Member Author

@asvetlov @kxepal

@kxepal
Copy link
Member

kxepal commented Feb 17, 2017

@fafhrd91
Ok with content-length - IIRC spec explicitly forbids that, but isn't chunked=True in arguments and transfer-encoding: chunked in headers are synonyms? Or I miss something?

@fafhrd91
Copy link
Member Author

fafhrd91 commented Feb 17, 2017 •
edited
Loading

If transfer-encoding is in headers we turn on chunking, and enable chunking on writer. But what if I want to chunk stream myself?

For content length we should raise exception if user pass it in headers and enables chunking

@fafhrd91 fafhrd91 mentioned this issue Feb 20, 2017
Closed
@fafhrd91
Copy link
Member Author

also we have to honor CONTENT-LENGTH header

@fafhrd91
Copy link
Member Author

fixed in 2.0

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
client good first issue Good for newcomers outdated
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@fafhrd91 @kxepal