Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom regexps in route variables #204

Closed
imbolc opened this issue Dec 24, 2014 · 8 comments
Closed

Support custom regexps in route variables #204

imbolc opened this issue Dec 24, 2014 · 8 comments
Labels

Comments

@imbolc
Copy link
Contributor

imbolc commented Dec 24, 2014

Is there a way to use slashes there? Or may be it is possible to use werkzeug router instead?

@asvetlov
Copy link
Member

You cannot directly use werkzeug (maybe possible to make adapter though).

What do you mean by slash usage? Redirecting to slash-trailing url when url is not ended by slash?

@imbolc
Copy link
Contributor Author

imbolc commented Dec 24, 2014

No, i am meaning usage slashes into {variable}, something like werkzeug
path converter:
http://werkzeug.pocoo.org/docs/0.9/routing/#werkzeug.routing.PathConverter
On Dec 24, 2014 3:04 PM, "Andrew Svetlov" [email protected] wrote:

You cannot directly use werkzeug (maybe possible to make adapter though).

What do you mean by slash usage? Redirecting to slash-trailing url when
url is not ended by slash?


Reply to this email directly or view it on GitHub
#204 (comment).

@asvetlov
Copy link
Member

Aaah, got it.

I can extend UrlDispather router to support routes like /path/{name:regex} where regex is any valid regexp pattern (like Pyramid does).

@imbolc
Copy link
Contributor Author

imbolc commented Dec 24, 2014

Yes it's what i need. Thank you :)
On Dec 24, 2014 4:49 PM, "Andrew Svetlov" [email protected] wrote:

Aaah, got it.

I can extend UrlDispather router to support routes like /path/{name:regex}
where regex is any valid regexp pattern (like Pyramid does).


Reply to this email directly or view it on GitHub
#204 (comment).

@asvetlov
Copy link
Member

Done in c7c5250 and c7c5250. Do you need new release?

@imbolc
Copy link
Contributor Author

imbolc commented Dec 24, 2014

Oh, it's more than enough, thanks a lot :)

@asvetlov asvetlov changed the title slashes in route variables Support custom regexps in route variables Dec 24, 2014
@asvetlov
Copy link
Member

Closing, will be available 0.13 release (or use master branch on your risk :)

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants