Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document about Access log cause confusion #2085

Closed
mapler opened this issue Jul 13, 2017 · 3 comments
Closed

Document about Access log cause confusion #2085

mapler opened this issue Jul 13, 2017 · 3 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers outdated
Milestone
2.3

Comments

@mapler
Copy link
Contributor

mapler commented Jul 13, 2017

Long story short

When I followed the document here to disable access log. It seems not working.

Expected behaviour

Just use app.make_handler(access_log=None) for disabling access log.

Steps to reproduce

app.make_handler(access_log=None)
web.run_app(app)

After I check the source code here. I know I make mistake about the usage of make_handler.
But I think run_app(app, access_log=None) is better and more clear than app.make_handler(access_log=None) in document.
@mapler mapler changed the title Access log disable not working Document about Access log cause confusion Jul 13, 2017
@asvetlov
Copy link
Member

Yes. Doc about logger disabling was created before introducing run_app() function.

Could you create a PR for doc update?

@asvetlov asvetlov added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 13, 2017
@asvetlov asvetlov added this to the 2.3.0 milestone Jul 13, 2017
mapler added a commit to mapler/aiohttp that referenced this issue Jul 13, 2017
@mapler
Fix docs (aio-libs#2085)
9f1486c 
mistake about disabling access logs.
@mapler mapler mentioned this issue Jul 13, 2017
Merged
2 tasks
asvetlov pushed a commit that referenced this issue Jul 13, 2017
@mapler @asvetlov
Fix docs (#2085) (#2086)
3516905 
mistake about disabling access logs.
@asvetlov
Copy link
Member

Fixed by #2085

@aio-libs-bot aio-libs-bot mentioned this issue Feb 20, 2019
Closed
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers outdated
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
2 participants
@asvetlov @mapler