-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileResponse sends empty chunked body when returning 304 #2143
Labels
Comments
Sounds reasonable. |
4 tasks
Fixed by cc614ca |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Long story short
FileResponse
(and by extension,add_static
) may returnTransfer-Encoding: chunked
and the empty chunked body when returning a 304 Not Modified, in violation of RFC 2616 §10.3.5, which states: "The 304 response MUST NOT contain a message-body, and thus is always terminated by the first empty line after the header fields."Expected behaviour
A 304 response with no body.
Actual behaviour
A 304 response with
Transfer-Encoding: chunked
and a 1-byte body (0
).Steps to reproduce
index.html
in the same directory:If-Modified-Since
that triggers a 304 Not Modified, e.g.The response will be something like:
Your environment
This is using aiohttp 2.2.3, the newest version at this time.
The text was updated successfully, but these errors were encountered: