Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent double closing when client connection is released before the last data_received() callback. #3079

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

asvetlov
Copy link
Member

Fix #3031

@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #3079 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3079      +/-   ##
=========================================
- Coverage   98.11%   98.1%   -0.02%     
=========================================
  Files          42      42              
  Lines        7750    7751       +1     
  Branches     1349    1350       +1     
=========================================
  Hits         7604    7604              
  Misses         51      51              
- Partials       95      96       +1
Impacted Files Coverage Δ
aiohttp/client_proto.py 95.36% <50%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b27f9...dadf259. Read the comment docs.

@asvetlov asvetlov merged commit cb7821c into master Jun 13, 2018
@asvetlov asvetlov deleted the prevent-double-closing branch June 13, 2018 12:44
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https:/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aiohttp request exceptions can't be caught sometimes when encountering bad http message
2 participants