Every request object is equal

[frmdstryr]

It seems the == operator evals to True for every request object.

from aiohttp.test_utils import make_mocked_request

def test_path_equals():
    req = make_mocked_request('GET', '/a/')
    req2 = make_mocked_request('GET', '/b/')
    assert req.path != req2.path
    assert req != req2

def test_method_equals():
    req = make_mocked_request('GET', '/a/')
    req2 = make_mocked_request('POST', '/a/')
    assert req.method != req2.method
    assert req != req2
    
def test_equals():
    req = make_mocked_request('GET', '/this/isnot/evenclose')
    req2 = make_mocked_request('OPTIONS', '/search?query=what')
    assert req.path != req2.path
    assert req.method != req2.method
    assert req != req2

Is this intentional?

[asvetlov]

The problem is exactly the same as #3107 for response
Comparison and hashing should be disabled for request objects.
I very curious what is your use case for requests comparison.

[frmdstryr]

The template engine I use builds a dom and automatically updates necessary parts of the page (form fields or user specific content) when the request changes.

Since all the requests were equal, it wasn't updating automatically. I just patched requests to use the id for comparison.

from aiohttp.web_request import BaseRequest

#: Equals returns true even though the requests are completely different
BaseRequest.__eq__ = lambda self, other: id(self) == id(other)

[asvetlov]

Understood. Thanks.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https:/aio-libs/aiohttp/issues/new