Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABCs should import from collections.abc in Py3.7+ #3275

Merged
merged 2 commits into from
Sep 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/3273.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix forward compatibility with Python 3.8: importing ABCs directly from the collections module will not be supported anymore.
1 change: 1 addition & 0 deletions CONTRIBUTORS.txt
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ Georges Dubus
Greg Holt
Gregory Haynes
Günther Jena
Gus Goulart
Gustavo Carneiro
Hu Bo
Hugo Herter
Expand Down
2 changes: 1 addition & 1 deletion aiohttp/web.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import socket
import sys
from argparse import ArgumentParser
from collections import Iterable
from collections.abc import Iterable
from importlib import import_module

from . import (helpers, web_app, web_exceptions, web_fileresponse,
Expand Down
2 changes: 1 addition & 1 deletion aiohttp/web_app.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import asyncio
import logging
import warnings
from collections import MutableMapping
from collections.abc import MutableMapping
from functools import partial
from typing import (TYPE_CHECKING, Any, Awaitable, Callable, List, Mapping,
Optional, Sequence, Tuple, Union)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_web_request.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import socket
from collections import MutableMapping
from collections.abc import MutableMapping
from unittest import mock

import pytest
Expand Down