Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -> None to ClientSession ctor #3339

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Conversation

graingert
Copy link
Contributor

What do these changes do?

This allows ClientSession to be constructed

Are there changes in behavior for the user?

Nope

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@graingert
Copy link
Contributor Author

Would be good to go though and add -> None to all ctors in this project

@codecov-io
Copy link

codecov-io commented Oct 10, 2018

Codecov Report

Merging #3339 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3339   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files          44       44           
  Lines        8039     8039           
  Branches     1357     1357           
=======================================
  Hits         7878     7878           
  Misses         67       67           
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc7eab9...6b14a65. Read the comment docs.

@asvetlov asvetlov merged commit 9ea8a02 into aio-libs:master Oct 10, 2018
@asvetlov
Copy link
Member

Would be good to go though and add -> None to all ctors in this project

Please do.
Thanks

@graingert graingert deleted the patch-2 branch October 10, 2018 19:05
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https:/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants