Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable too agressive flake8 errors #3425

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Dec 3, 2018

New flake8 tool blames too much.

I prefer to suppress innocent reported errors over fixing all reported lines.
Let's wait for black adoption to auto-reformat code without boring manual fixes.

@codecov-io
Copy link

codecov-io commented Dec 3, 2018

Codecov Report

Merging #3425 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3425      +/-   ##
==========================================
- Coverage   97.92%   97.92%   -0.01%     
==========================================
  Files          44       44              
  Lines        8534     8626      +92     
  Branches     1378     1434      +56     
==========================================
+ Hits         8357     8447      +90     
  Misses         72       72              
- Partials      105      107       +2
Impacted Files Coverage Δ
aiohttp/web_urldispatcher.py 99.25% <100%> (ø) ⬆️
aiohttp/base_protocol.py 97.46% <0%> (+0.54%) ⬆️
aiohttp/web_protocol.py 93.27% <0%> (+1.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a1174...c6b68fe. Read the comment docs.

@asvetlov asvetlov merged commit b02a608 into master Dec 3, 2018
@asvetlov asvetlov deleted the disable-flake-errors branch December 3, 2018 21:09
@lock
Copy link

lock bot commented Dec 3, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Dec 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants